Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DELEG, POOL, GOVCERT conformance with Spec v0.8 #3628

Merged
merged 1 commit into from
Aug 17, 2023
Merged

DELEG, POOL, GOVCERT conformance with Spec v0.8 #3628

merged 1 commit into from
Aug 17, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Aug 9, 2023 •
edited by lehins

Description

Resolves #3442 , #3638, #3646, #3649

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested a review from WhatisRT August 9, 2023 14:36
@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch 3 times, most recently from 7d26ca3 to 4b486ae Compare August 11, 2023 12:54
@aniketd aniketd marked this pull request as ready for review August 11, 2023 12:55
@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch from 4b486ae to bfad8bb Compare August 11, 2023 13:30
Soupstraw
Soupstraw requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going over the code, it's always nice to have someone double-check these things. I think it would make more sense to turn some of the TODO comments in this PR into issues and then maybe merge some of the predicate failure improvements. The logic already seemed to be correct, so I don't think it should be changed.

@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch from bfad8bb to 45e803c Compare August 14, 2023 21:33
@aniketd aniketd requested a review from Soupstraw August 14, 2023 21:33
@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch 2 times, most recently from da32124 to f276bed Compare August 14, 2023 21:47
@aniketd aniketd requested a review from WhatisRT August 14, 2023 21:48
lehins
lehins requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. DRep deposits are missing, but that can be done as a follow up PR.

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Cert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/GovCert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Certs.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Certs.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Certs.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/GovCert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/GovCert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/GovCert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/GovCert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/GovCert.hs Outdated Show resolved Hide resolved
@aniketd aniketd requested a review from lehins August 16, 2023 12:17
@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch from 5eed3e3 to 7c1d9d7 Compare August 16, 2023 12:23
lehins
lehins reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, my previous suggestion was slightly off.

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Certs.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Certs.hs Outdated Show resolved Hide resolved
lehins
lehins approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to go, once other minor comments that I made are addressed.

@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch from 7c1d9d7 to 59601f4 Compare August 16, 2023 13:06
@aniketd aniketd enabled auto-merge August 16, 2023 13:06
@aniketd aniketd disabled auto-merge August 16, 2023 13:23
@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch from 59601f4 to 27f418b Compare August 16, 2023 17:03
@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch 2 times, most recently from 840bcad to 3a9d387 Compare August 16, 2023 18:21
@aniketd
Copy link
Contributor Author

aniketd commented Aug 16, 2023

Since DRep expiry update has been moved from CERTS to LEDGER, this definitely needs another review (at least that part does) @lehins @Soupstraw

@aniketd aniketd requested a review from Soupstraw August 17, 2023 09:46
@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch from 3a9d387 to ea91fdd Compare August 17, 2023 11:08
@aniketd aniketd force-pushed the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch from ea91fdd to 490c638 Compare August 17, 2023 11:24
@aniketd
Copy link
Contributor Author

aniketd commented Aug 17, 2023

@Soupstraw need you approval here 👑

Soupstraw
Soupstraw approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aniketd aniketd enabled auto-merge August 17, 2023 11:29
@aniketd aniketd merged commit bbdfc3f into master Aug 17, 2023
10 of 13 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/deleg-pool-gstate-certs-spec-v0-8-conformance branch August 17, 2023 14:56
@lehins lehins mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@Soupstraw Soupstraw Soupstraw approved these changes

@teodanciu teodanciu Awaiting requested review from teodanciu

@TimSheard TimSheard Awaiting requested review from TimSheard

@WhatisRT WhatisRT Awaiting requested review from WhatisRT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conway Certs
4 participants
@aniketd @WhatisRT @lehins @Soupstraw