Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented DRep refreshing #3630

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Implemented DRep refreshing #3630

merged 1 commit into from
Aug 11, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Aug 9, 2023

Description

resolves #3621

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/drep-refresh branch 4 times, most recently from 40b4109 to 0bb2f70 Compare August 10, 2023 12:17
@Soupstraw Soupstraw marked this pull request as ready for review August 10, 2023 12:17
@Soupstraw Soupstraw requested review from lehins, aniketd and teodanciu and removed request for lehins August 10, 2023 12:17
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@Soupstraw Soupstraw enabled auto-merge (rebase) August 10, 2023 13:23
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soupstraw I have some questions 😸

@Soupstraw Soupstraw force-pushed the jj/drep-refresh branch 3 times, most recently from 5f413c4 to a5410cc Compare August 10, 2023 14:43
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Awesome job! ❤️

@Soupstraw Soupstraw merged commit bf2dc0f into master Aug 11, 2023
@iohk-bors iohk-bors bot deleted the jj/drep-refresh branch August 11, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to refresh the DRep timeout
4 participants