Prevent state changes on phase2 failure #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for correctness. We should only validate the UTXO rules when transaction is marked as invalid, because we should only collect the collateral when phase2 is expected to fail. There is also no requirement for `CERTS` or `GOV` rule run validation if we only collect the collateral.
lehins
force-pushed
the
lehins/prevent-state-changes-on-phase2-failure
branch
from
b3e681c to
1d51541
Compare
teodanciu
reviewed
Aug 10, 2023
aniketd
reviewed
Aug 10, 2023
iohk-bors
bot
deleted the
lehins/prevent-state-changes-on-phase2-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents phase1 validation and state changes when
isValid = FalseThis is necessary for correctness.We should only validate the UTXO rules when transaction is marked as invalid, because we should only collect the collateral when phase2 is expected to fail.
There is no requirement for
CERTSorGOVrule run validation if we only collect the collateral.Also renames:
cgGov[L]->cgGovActionsState[L]cgRatify[L]->cgRatifyState[L]Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)