Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance queries #3648

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Governance queries #3648

merged 3 commits into from
Aug 15, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Aug 14, 2023 •
edited by nfrisby
Loading

Description

This PR implements 5 queries for consensus:

  • GetGovState
  • GetDRepState
  • GetDRepStakeDistr
  • GetCommitteeState
  • GetConstitution

Also it adds a newtype CommitteeState

And fixes #3624

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

(Edit: After the PR was merged, I updated this description to also mention the fifth added query, GetConstitution.)

@lehins lehins requested review from Soupstraw and teodanciu August 14, 2023 20:07
@lehins
Introduce CommitteeState. Adjust VState.
8afeb6e 
* Addition of a whole new `CommitteeState` type will be useful for
  implementing a consensus query. It will also be needed for #3647
* Also fixes #3624
@lehins lehins force-pushed the lehins/governance-query branch from 1065d38 to e9c3197 Compare August 15, 2023 10:03
@lehins lehins force-pushed the lehins/governance-query branch from e9c3197 to f759482 Compare August 15, 2023 13:52
teodanciu
teodanciu approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins enabled auto-merge August 15, 2023 14:43
@lehins lehins merged commit d4dfc0e into master Aug 15, 2023
@iohk-bors iohk-bors bot deleted the lehins/governance-query branch August 15, 2023 15:46
@carbolymer carbolymer mentioned this pull request Aug 22, 2023
Merged
10 tasks
@lehins lehins mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodanciu teodanciu teodanciu approved these changes

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Ord instance for DRepState
2 participants
@lehins @teodanciu