Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change environment for ShelleyPOOLREAP rule #3650

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Aug 15, 2023

Description

Previous type for environment was PParams, which was unused. Current environment is set to VState, because it will be needed for correct implemention of obligationCertState used in the rule's assertion. It will be needed for DRep deposits: #3645

Also rename CDDL Committee certificates variables:

  • reg_committee_hot_key_cert -> auth_committee_hot_cert
  • unreg_committee_hot_key_cert -> resign_committee_cold_cert

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Previous type for environment was `PParams`, which was unused. Current
environment is set to `VState`, because it will be needed for
correct implemention of `obligationCertState` used in the rule's
assertion. It will be needed for DRep deposits: #3645
@lehins lehins requested a review from Soupstraw August 15, 2023 16:00
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the VState!

@Soupstraw Soupstraw merged commit 2f62afd into master Aug 16, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the lehins/adjust-poolreap-env branch August 16, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants