Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inactive DReps #3651

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Inactive DReps #3651

merged 4 commits into from
Aug 21, 2023

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Aug 15, 2023 •
edited
Loading

Don't count inactive (expired) DReps in Ratification

Closes #3448

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/inactive-dreps branch 3 times, most recently from dec234a to 28a4c67 Compare August 17, 2023 13:51
@teodanciu teodanciu marked this pull request as ready for review August 17, 2023 13:51
@teodanciu teodanciu changed the title [WIP] Inactive DReps Inactive DReps Aug 17, 2023
@teodanciu teodanciu force-pushed the td/inactive-dreps branch 8 times, most recently from 781c3ce to cc6428f Compare August 21, 2023 13:10
lehins
lehins approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a few minor suggestions this looks great! Thank you!

eras/conway/impl/CHANGELOG.md Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ratify.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ratify.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/RatifySpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/RatifySpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/RatifySpec.hs Outdated Show resolved Hide resolved
@teodanciu teodanciu enabled auto-merge (rebase) August 21, 2023 18:19
@teodanciu teodanciu merged commit 367e3ce into master Aug 21, 2023
@iohk-bors iohk-bors bot deleted the td/inactive-dreps branch August 21, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inactive DReps
2 participants
@teodanciu @lehins