Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proposal deposit check against PParam #3669

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Aug 23, 2023

Description

Closes #3665

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Also remove TODO assignment in code comments so anyone can address them in future
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
@lehins lehins enabled auto-merge August 23, 2023 11:59
@lehins lehins merged commit a6f8597 into master Aug 23, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/govaction-deposit branch August 23, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate GovAction deposit
2 participants