Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor patch that fixes the DRep distribution computation #3677

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Aug 24, 2023

Description

This is a minor patch that fixes the DRep distribution computation

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@@ -1,5 +1,9 @@
# Version history for `cardano-ledger-conway`

## 1.7.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, given that the actual code change is in master, does this mean that this changelog entry will for 1.7.1.0 will never be past of master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, whenever a release happens not from HEAD of master, there needs to be an adjustment to versions and changelog on master

@lehins lehins merged commit 750fe6b into release/cardano-ledger-conway-shelley-base-branch Aug 25, 2023
22 checks passed
@iohk-bors iohk-bors bot deleted the release/cardano-ledger-conway-shelley-minor-patch-release-drep-distr branch August 25, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants