Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new bench mark programs #3683

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Add two new bench mark programs #3683

merged 3 commits into from
Aug 28, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Aug 27, 2023

Description

Add two new bench mark programs

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how useful these benchmarks are, but I don't see any harm in adding them.

Run this using `cabal bench umap`.
The code decode function is `decodeAddrStateAllowLeftoverT` and we bench
this via `decodeAddrEither`.

Run this with `cabal bench addr`.
@lehins lehins enabled auto-merge August 28, 2023 20:35
@lehins lehins merged commit 642b86e into master Aug 28, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the erikd/umap-size-bench branch August 28, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants