Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post patch release fixup #3686

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Post patch release fixup #3686

merged 3 commits into from
Aug 30, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Aug 28, 2023

Description

This PR fixes:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu
Copy link
Contributor

Hm, seems like after Make snapshots of GovActionsState , a few more packages needed their version updated, because of version change of their dependency, no?

cardano-ledger-allegra to 1.2.2.1
cardano-ledger-alonzo to 1.4.1.1
cardano-ledger-alonzo-test to 1.1.2.5
cardano-ledger-babbage to 1.4.4.1
cardano-ledger-babbage-test to 1.1.1.6
conway-ledger-conway to 1.8.0.1
cardano-ledger-pretty to 1.3.0.3
cardano-protocol-tpraos to 1.0.3.6

But the changes in this PR are still valid, so we can add these afterwards. I'm happy to make a PR with these if you like

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins force-pushed the lehins/post-patch-release-fixup branch from fa00c7a to b956ae1 Compare August 30, 2023 13:26
@lehins lehins enabled auto-merge August 30, 2023 13:26
@lehins lehins disabled auto-merge August 30, 2023 13:34
lehins added 3 commits August 30, 2023 15:34
* `cardano-ledger-shelley-1.5.1.o`
* `cardano-ledger-conway-1.7.1.0`
* `cardano-ledger-shelley-ma-test-1.2.1.3`
* `cardano-ledger-shelley-test-1.2.0.4`

Also fixup the CHANGELOGs for the two packages. Somehow versions got
bumped twice.
@lehins lehins force-pushed the lehins/post-patch-release-fixup branch from b956ae1 to 191f601 Compare August 30, 2023 13:36
@lehins lehins enabled auto-merge August 30, 2023 13:36
@lehins
Copy link
Collaborator Author

lehins commented Aug 30, 2023

Hm, seems like after Make snapshots of GovActionsState , a few more packages needed their version updated, because of version change of their dependency, no?

@teodanciu That is not correct. All of these packages already had a version bump. In fact I noticed thanks to your comment that cardano-ledger-pretty had been already bumped twice (which is what your comment suggests to do for all of the packages in the list). The released version is cardanoledger-pretty-1.3.0.0, but version on master in cabal file on master is cardanoledger-pretty-1.3.0.2. We should not skip versions like that without actual releases. Also versions in CHNAGELOG should always match, except when there are no changes in a package when compared to the currently released version.

@lehins lehins merged commit d14ff95 into master Aug 30, 2023
@iohk-bors iohk-bors bot deleted the lehins/post-patch-release-fixup branch August 30, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants