Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting on the postive coin decoder #3694

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Aug 30, 2023

Description

Better error reporting for decodePositiveCoin decoder.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/improve-error-reporting branch from c21a06d to 560c00f Compare August 30, 2023 23:58
@lehins lehins force-pushed the lehins/improve-error-reporting branch from 560c00f to c995ce3 Compare August 30, 2023 23:58
@lehins lehins requested a review from aniketd August 30, 2023 23:59
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🙌

@lehins lehins merged commit 4694722 into master Aug 31, 2023
@iohk-bors iohk-bors bot deleted the lehins/improve-error-reporting branch August 31, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants