Rewrite testEql using Typeable to make it impossible to forget cases

[MaximilianAlgehed]

Description

Everything is Typeable so we can use that to reduce some clutter.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated
• When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
  versioning process.
• The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
• All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
• Code is formatted with fourmolu (use scripts/fourmolize.sh)
• Cabal files are formatted (use scripts/cabal-format.sh)
• hie.yaml has been updated (use scripts/gen-hie.sh)
• Self-reviewed the diff

[MaximilianAlgehed]

@lehins and @TimSheard it would be good to get this reviewed and merged.

[lehins]

This is awesome. I love how IsTypeable solves this source of mistakes when adding new Rep constructors: https://github.com/input-output-hk/cardano-ledger/blob/9e2f8151e3b9a0dde9faeb29a7dd2456e854427c/libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/TypeRep.hs#L417

[MaximilianAlgehed]

@lehins could you please run the checks? I think this is the final version of the PR.

[lehins]

@MaximilianAlgehed This PR needs to be rebases on master. Whenever you see this at the bottom of the PR this is necessary for merging:

This branch is out-of-date with the base branch

[MaximilianAlgehed]

@lehins done

[MaximilianAlgehed]

@lehins something appears to be broken in CI.

[lehins]

@MaximilianAlgehed Looks like some issue with Github since yesterday. Traballs don't get downloaded fully or corrupted. This happens on multiple repos that we have.

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive

[lehins]

@MaximilianAlgehed Looks like Github has finally back to normal operation since yesterday. Just in case I implemented a fallback workaround too in #3713

Do you mind rebasing again on master again? We've had a few PRs merged yesterday.

[MaximilianAlgehed]

@lehins still broken?

[lehins]

@lehins still broken?

@MaximilianAlgehed Why do you say it is broken? CI hasn't finished yet. (Only "Required" ones are important)

[MaximilianAlgehed]

Right... So the one thats called ci is irrelevant to CI?

[lehins]

Right... So the one thats called ci is irrelevant to CI?

It is relevant, but it just doesn't work for forked repos, I think. In any case it is not terribly reliable, but it is useful, since it runs CI in nix, where GithubActions is build with regular cabal setup without nix.

[MaximilianAlgehed]

Perfect, thanks for clearing that up. I won't care about that one in the future when working from our fork. Den tors 7 sep. 2023 12:41Alexey Kuleshevich ***@***.***> skrev:

…

Right... So the one thats called ci is irrelevant to CI? It is relevant, but it just doesn't work for forked repos, I think. In any case it is not terribly reliable, but it is useful, since it runs CI in nix, where GithubActions is build with regular cabal setup without nix. — Reply to this email directly, view it on GitHub <#3697 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBPPQN4JAPPOSFDWLVURDDXZGQETANCNFSM6AAAAAA4HJFO4I> . You are receiving this because you were mentioned.Message ID: ***@***.***>