Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release changes #3708

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Post release changes #3708

merged 3 commits into from
Sep 6, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Sep 5, 2023

Description

There was a release of ledger packages today: https://github.com/input-output-hk/cardano-haskell-packages/pull/472. Need to account for it.

Also workaround an intermittent issue with GitHub

Also fix the wrong path in the cabal file

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested review from a team as code owners September 5, 2023 18:13
@lehins lehins requested a review from teodanciu September 5, 2023 20:01
@lehins lehins force-pushed the lehins/post-release-changes branch from d2c6a0c to 523844a Compare September 5, 2023 20:04
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it seems like this ledger release was quite smooth, with no fixes necessary for the Chap build to work, awesome 🙌

@lehins lehins force-pushed the lehins/post-release-changes branch from 523844a to e256830 Compare September 5, 2023 21:23
@lehins lehins force-pushed the lehins/post-release-changes branch from e256830 to 2c30ca4 Compare September 5, 2023 21:54
@lehins lehins enabled auto-merge September 5, 2023 21:55
@lehins lehins merged commit 5d04a8c into master Sep 6, 2023
@iohk-bors iohk-bors bot deleted the lehins/post-release-changes branch September 6, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants