Predicate failure for mismatched Voter GovAction #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
commented
Sep 8, 2023
teodanciu
reviewed
Sep 8, 2023
teodanciu
reviewed
Sep 8, 2023
teodanciu
reviewed
Sep 8, 2023
teodanciu
reviewed
Sep 8, 2023
|
If you want, you could squash the first 3 commits, to have a cleaner commit history, since they are a meaningful unit together |
lehins
requested changes
Sep 11, 2023
lehins
reviewed
Sep 11, 2023
lehins
reviewed
Sep 11, 2023
lehins
reviewed
Sep 11, 2023
lehins
force-pushed
the
lehins/simplify-threshold
branch
from
c342166 to
565e8ef
Compare
aniketd
force-pushed
the
aniketd/invalid-voter-govaction-pair-predicate-failure
branch
from
e55a48b to
1fa37e0
Compare
|
Could you please rebase on master? |
lehins
force-pushed
the
aniketd/invalid-voter-govaction-pair-predicate-failure
branch
from
1fa37e0 to
8188a7d
Compare
lehins
requested changes
Sep 11, 2023
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Snapshots.hs
Outdated
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/invalid-voter-govaction-pair-predicate-failure
branch
from
87f6b36 to
b7e1f4f
Compare
aniketd
commented
Sep 12, 2023
teodanciu
reviewed
Sep 12, 2023
aniketd
commented
Sep 12, 2023
aniketd
commented
Sep 12, 2023
aniketd
force-pushed
the
aniketd/invalid-voter-govaction-pair-predicate-failure
branch
from
a5837d6 to
00461b7
Compare
- Fix naming in `toPrevGovActionIds{Paris}` to `Pairs`
- Add new inhabitant to `ConwayGovPredFailure`:
- `DisallowedVoters (Map (GovActionId c) (Voter c))`
In `ConwayGOV`, we make sure to introduce new data-structures and
references most minimally, by reusing the required ones between
`noSuchGovActions` and `checkVotesAreValid` tests. This is achieved by
first preparing a `govActionIdVotes`. @lehins is the wizard behind
conjuring these important optimizations.
The `NewConstitution` proposal test in `ConwayFeatures` needed to be
reduced to only using votes from DReps, i.e. votes from SPOs have been
removed as they were incorrect to begin with.
Co-authored-by: Alexey Kuleshevich <lehins@yandex.ru>
aniketd
force-pushed
the
aniketd/invalid-voter-govaction-pair-predicate-failure
branch
from
00461b7 to
e73c242
Compare
iohk-bors
bot
deleted the
aniketd/invalid-voter-govaction-pair-predicate-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3685
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)