Conway and other eras roundtrip tests #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/add-ledger-state-roundtrip-tests
branch
from
a503388 to
3932c4c
Compare
|
Still needs a changeklog update and git history cleanup, but other than that is ready for review. |
teodanciu
reviewed
Sep 12, 2023
lehins
force-pushed
the
lehins/add-ledger-state-roundtrip-tests
branch
2 times, most recently
from
39e275f to
940ffa1
Compare
teodanciu
reviewed
Sep 12, 2023
teodanciu
reviewed
Sep 12, 2023
teodanciu
reviewed
Sep 12, 2023
lehins
force-pushed
the
lehins/add-ledger-state-roundtrip-tests
branch
3 times, most recently
from
6686cd0 to
7e6f8b7
Compare
teodanciu
reviewed
Sep 13, 2023
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Binary/RoundTrip.hs
Show resolved
Hide resolved
teodanciu
approved these changes
Sep 13, 2023
…redential`: * use `keyHash` vs `key hash`/`keyhash` * use `scriptHash` vs `script hash`/`scripthash` Variants with space and without space are still parseable for backwards compatibility
Generating nested data structures like Maps within Maps is prohbitively expensive. In Alonzo we have CostModels present in PParams, which results in too much data being generated for `ProposedPPUpdates`.
* Structure CBOR RoundTrip tests in reusable manner from era to era * Improve roundtrip failure reporting * Arbitrary for DRepDistr
lehins
force-pushed
the
lehins/add-ledger-state-roundtrip-tests
branch
from
7e6f8b7 to
33ecc2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR organizes CBOR RoundTrip tests into a nice hierarchy
It captures all of the Conway types and most of the types from other eras, but not all of them. Fixes: #3158
One important one is still missing is CBOR RoundTrip tests for PredicateFailures, but we can take care of it as a separate task.
Besides tests there other notable changes:
ProposalsSnapshotToJSON/FromJSONimplementation ofCredentialChecklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)