-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRep expiry update after a contiguous set of epochs with no proposals to vote on #3729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
008bf4e
to
25de335
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!!! 👍
@aniketd Needs golden test adjustment, since we added a new field and some other test failures. Not sure what they are about |
25de335
to
86ffe22
Compare
This field counts the number of contiguous epochs in which the number of active governance proposals that can be voted on, remained zero. It will be incremented in every EPOCH if the number of active governance actions that can be voted on, remains zero. It will be reset when a new governance proposal is submitted successfully.
481001f
to
9b0a83d
Compare
In EPOCH, we make sure to update the dormant-epochs counter every time we see that the previous epoch didn't have any governance proposals to vote on. When there is a new governance proposal in a transaction AND the dormant-epochs counter is greater than zero, we 1. Update the expiry for all DReps by adding the counter 2. Reset the dormant-epochs counter We update Api.State.Query.queryDRepState to report the effective DRep expiry information. Add snapshotsGovStateL to ConwayEraGov Move asks out of loop in GOV Update changelogs and bump packages
9b0a83d
to
9fb1af8
Compare
b182e83
to
d4a6691
Compare
d4a6691
to
1b845d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! 🙂
Description
Closes #3723
vsNumDormantEpochs
field toVState
.EPOCH
if the number of active governance actions that can be voted on continues to remain zero. It will be reset when a new governance proposal is submitted successfullyChecklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)