Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some unit tests for Conway features #3733

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add some unit tests for Conway features #3733

merged 1 commit into from
Sep 29, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Sep 15, 2023 •
edited by lehins
Loading

Description

  • Added ToExpr instances to Conway NewEpochState and all the data types that it depends on

  • Added the ImpTest DSL to make it easier to write unit tests. Fixes Simplify ConwayFeatures with a testing DSL #3689

  • Implemented a few tests using the ImpTest DSL

  • Moved some testing helper functions to cardano-ledger-core:testlib or cardano-ledger-conway:testlib

  • Also fixes Basic Conway tests #3493

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/conway-tests branch 9 times, most recently from 0f655c7 to d41862c Compare September 20, 2023 11:01
@Soupstraw Soupstraw requested a review from aniketd September 20, 2023 11:15
@Soupstraw Soupstraw force-pushed the jj/conway-tests branch 5 times, most recently from 2f34740 to 7586739 Compare September 20, 2023 12:09
@Soupstraw Soupstraw marked this pull request as ready for review September 20, 2023 12:09
@Soupstraw Soupstraw force-pushed the jj/conway-tests branch 11 times, most recently from 1e848c9 to 36a183b Compare September 22, 2023 13:17
@Soupstraw Soupstraw force-pushed the jj/conway-tests branch 10 times, most recently from 85ad47d to d820590 Compare September 28, 2023 10:59
lehins
lehins approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could still use a few slight improvements and cleanups, other than that it could already be merged

Very nice work!!

eras/conway/impl/test/Test/Cardano/Ledger/Conway/EpochSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Serialisation/GoldenUtils.hs Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw mentioned this pull request Sep 28, 2023
Closed
@Soupstraw Soupstraw force-pushed the jj/conway-tests branch 10 times, most recently from 42542d0 to 169969b Compare September 28, 2023 14:54
@Soupstraw Soupstraw enabled auto-merge (rebase) September 28, 2023 14:56
@Soupstraw Soupstraw force-pushed the jj/conway-tests branch 2 times, most recently from c1597ba to c346776 Compare September 29, 2023 09:28
@Soupstraw
Added ImpTest DSL for writing unit tests
5e7cca7 
Added ToExpr instances
Moved ImpTest to cardano-ledger-conway:testlib
Moved ConwayEpochs to cardano-ledger-conway:test
@Soupstraw Soupstraw merged commit 131173c into master Sep 29, 2023
@iohk-bors iohk-bors bot deleted the jj/conway-tests branch September 29, 2023 11:20
@lehins lehins mentioned this pull request Sep 29, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketd aniketd aniketd approved these changes

@teodanciu teodanciu teodanciu left review comments

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify ConwayFeatures with a testing DSL Basic Conway tests
4 participants
@Soupstraw @aniketd @teodanciu @lehins