Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some PParams to be consistent with Agda specification #3739

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Sep 19, 2023

Description

Closes #3732

  • Rename ConwayPParams to be consistent with the Agda specification. #
    • govActionExpiration to govActionLifetime
    • committeeTermLimit to committeeMaxTermLength
    • minCommitteeSize to committeeMinSize

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

eras/conway/impl/test/data/conway-genesis.json Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/consistent-rename-pparams branch from 2c8075c to 6001f6d Compare September 19, 2023 16:00
@lehins
Copy link
Contributor

lehins commented Sep 19, 2023

@aniketd I've merged your other PR, so there are some conflicts. Could you rebase on master and squash the commits? Other than that this PR is ready to be merged.

@aniketd aniketd force-pushed the aniketd/consistent-rename-pparams branch from 6001f6d to 9925760 Compare September 19, 2023 16:59
@aniketd aniketd enabled auto-merge (squash) September 19, 2023 16:59
@aniketd aniketd merged commit bcec198 into master Sep 19, 2023
9 of 11 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/consistent-rename-pparams branch September 19, 2023 19:07
mirceahasegan added a commit to input-output-hk/cardano-js-sdk that referenced this pull request Apr 16, 2024
mirceahasegan added a commit to input-output-hk/cardano-js-sdk that referenced this pull request Apr 18, 2024
mirceahasegan added a commit to input-output-hk/cardano-js-sdk that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename few PParams for consistency with the spec
2 participants