-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some PParams to be consistent with Agda specification #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
2c8075c
to
6001f6d
Compare
@aniketd I've merged your other PR, so there are some conflicts. Could you rebase on master and squash the commits? Other than that this PR is ready to be merged. |
6001f6d
to
9925760
Compare
mirceahasegan
added a commit
to input-output-hk/cardano-js-sdk
that referenced
this pull request
Apr 16, 2024
…term_length Origin of rename IntersectMBO/cardano-ledger#3739
mirceahasegan
added a commit
to input-output-hk/cardano-js-sdk
that referenced
this pull request
Apr 18, 2024
…term_length Origin of rename IntersectMBO/cardano-ledger#3739
mirceahasegan
added a commit
to input-output-hk/cardano-js-sdk
that referenced
this pull request
May 31, 2024
…term_length Origin of rename IntersectMBO/cardano-ledger#3739
mirceahasegan
added a commit
to input-output-hk/cardano-js-sdk
that referenced
this pull request
Jun 11, 2024
…term_length Origin of rename IntersectMBO/cardano-ledger#3739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3732
ConwayPParams
to be consistent with the Agda specification. #govActionExpiration
togovActionLifetime
committeeTermLimit
tocommitteeMaxTermLength
minCommitteeSize
tocommitteeMinSize
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)