Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DRepDistr from VState to ConwayGovState #3743

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Move DRepDistr from VState to ConwayGovState #3743

merged 2 commits into from
Sep 20, 2023

Conversation

TimSheard
Copy link
Contributor

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

lehins
lehins reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preliminary feedback. Other than that I think we are on the right track

eras/conway/impl/src/Cardano/Ledger/Conway/Governance.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/NewEpoch.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-api/src/Cardano/Ledger/Api/State/Query.hs Outdated Show resolved Hide resolved
lehins
lehins approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!!!

@lehins lehins changed the title WIP. Move DRepDistr from VState to ConwayGovState Move DRepDistr from VState to ConwayGovState Sep 20, 2023
@lehins lehins merged commit 615fdfb into master Sep 20, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the ts-redo-drepdistr branch September 20, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimSheard @lehins