Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDDL for praos headers. #3762

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Update CDDL for praos headers. #3762

merged 1 commit into from
Sep 27, 2023

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Sep 27, 2023

Description

cardano-protocol-praos does not inline ocert and protocol version into the header, treating them instead as nested objects. This is not accurately reflected in the CDDL.

This is a stopgap solution, since this can no longer be tested here due to cardano-protocol-praos living in the consensus repository.

Addresses #3559

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

cardano-protocol-praos does not inline ocert and protocol version into
the header, treating them instead as nested objects. This is not
accurately reflected in the CDDL.

This is a stopgap solution, since this can no longer be tested here due
to cardano-protocol-praos living in the consensus repository.
@lehins lehins merged commit ccc7595 into master Sep 27, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the nc/babbage-cddl branch September 27, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants