Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail proposal on invalid prevGovActionId #3768

Merged
merged 7 commits into from
Oct 9, 2023
Merged

Fail proposal on invalid prevGovActionId #3768

merged 7 commits into from
Oct 9, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Sep 28, 2023 •
edited

Description

Closes #3655

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/validate-previous-gov-action-id-on-proposal branch from 934ff37 to b8c6c13 Compare September 28, 2023 15:29
lehins
lehins requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, but I am not 100% sure. Besides addressing the comments could I as you to write a couple of unit test using the DSL that was implemented in #3733

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/validate-previous-gov-action-id-on-proposal branch 3 times, most recently from 006f73b to b11a16d Compare October 3, 2023 11:34
@aniketd aniketd requested a review from lehins October 3, 2023 11:34
@aniketd aniketd force-pushed the aniketd/validate-previous-gov-action-id-on-proposal branch from 3fc7620 to ae18d54 Compare October 5, 2023 16:20
lehins
lehins requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one important change that is needed and a few other minor improvements

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/GovSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/GovSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/GovSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/GovSpec.hs Show resolved Hide resolved
@lehins lehins mentioned this pull request Oct 5, 2023
Closed
@aniketd aniketd force-pushed the aniketd/validate-previous-gov-action-id-on-proposal branch from ae18d54 to dd9f1cf Compare October 9, 2023 09:30
@aniketd aniketd requested a review from lehins October 9, 2023 09:30
lehins
lehins approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Very nice.

@lehins lehins merged commit 3b97449 into master Oct 9, 2023
13 of 15 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/validate-previous-gov-action-id-on-proposal branch October 9, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodanciu teodanciu teodanciu left review comments

@lehins lehins lehins approved these changes

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate previous governance action id upon proposal
3 participants
@aniketd @teodanciu @lehins