Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal.project: Bump index states #3770

Merged
merged 3 commits into from
Oct 5, 2023
Merged

cabal.project: Bump index states #3770

merged 3 commits into from
Oct 5, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Sep 29, 2023

This is the first step in making this build with ghc-9.8. Only the index-state values were changed.

@erikd erikd requested review from michaelpj and lehins September 29, 2023 04:30
@lehins
Copy link
Collaborator

lehins commented Sep 29, 2023

Whenever index state is updated we also need to update nix flakes

@erikd erikd force-pushed the erikd/deps-20230928 branch from 7fbb64f to 689fdb3 Compare October 3, 2023 04:18
@erikd erikd requested review from a team as code owners October 3, 2023 04:18
@erikd
Copy link
Contributor Author

erikd commented Oct 3, 2023

@lehins Updating the CHaP index-state was easy:

nix flake lock --update-input CHaP

However, I tried every combination I could think of for

nix flake lock --update-input hackage.nix

and none of them worked.

@michaelpj
Copy link
Contributor

@erikd
Copy link
Contributor Author

erikd commented Oct 3, 2023

@erikd it's written down: https://github.com/input-output-hk/cardano-ledger/blob/master/CONTRIBUTING.md?plain=1#L64

So why is it different between projects? I have touched 10 different input-output-hk projects in the last week. Every project doing it in a unique snowflake way is a HUGE pain in the neck.

@erikd erikd force-pushed the erikd/deps-20230928 branch 2 times, most recently from b8e4ae3 to 49661b1 Compare October 4, 2023 05:41
@lehins lehins force-pushed the erikd/deps-20230928 branch from a2d242d to 692707b Compare October 5, 2023 19:07
@lehins lehins enabled auto-merge (squash) October 5, 2023 19:07
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins merged commit b46c002 into master Oct 5, 2023
@iohk-bors iohk-bors bot deleted the erikd/deps-20230928 branch October 5, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants