Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed how costmodel updates are applied #3771

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Sep 29, 2023

Description

Cost model updates now apply updates for each plutus version separately instead of overwriting the whole cost models field in PParams.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/costmodels-update branch 2 times, most recently from 18241d6 to 9a98347 Compare September 29, 2023 12:04
@Soupstraw Soupstraw requested review from lehins, aniketd and teodanciu and removed request for lehins September 29, 2023 12:05
@Soupstraw Soupstraw marked this pull request as ready for review September 29, 2023 12:05
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. I love how simple this solution is!

@lehins lehins enabled auto-merge September 29, 2023 12:18
@lehins lehins disabled auto-merge September 29, 2023 12:19
@Soupstraw Soupstraw force-pushed the jj/costmodels-update branch 2 times, most recently from 12963f9 to 1c7184b Compare September 29, 2023 14:02
@Soupstraw Soupstraw enabled auto-merge (rebase) September 29, 2023 14:44
@Soupstraw Soupstraw merged commit de7c29e into master Sep 29, 2023
@iohk-bors iohk-bors bot deleted the jj/costmodels-update branch September 29, 2023 15:52
@lehins lehins mentioned this pull request Nov 2, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants