-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a Data.OMap.Strict to replace ProposalsSnapshot #3791
Conversation
8ab8cec
to
35c4175
Compare
c3d7100
to
aed1589
Compare
aed1589
to
0093b6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an unfortunate problem with the decision of using a SSeq of v
instead of SSeq
of k
. I commented on the actual location where the problem is. We can discuss tomorrow some possible solutions
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Snapshots.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Snapshots.hs
Outdated
Show resolved
Hide resolved
0093b6f
to
4ab174c
Compare
7049e56
to
8d59f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't look closely enough last time. A whole bunch more comments.
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Snapshots.hs
Outdated
Show resolved
Hide resolved
8d59f07
to
9a07dac
Compare
9a07dac
to
fab43fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dammit, I reviewed the PR last night, but forgot to hit Submit Review
Looks much better. Couple of minor points still exist, but they should be easy to fix
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs
Outdated
Show resolved
Hide resolved
fab43fc
to
11b3410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👍
0742eb6
to
89af4f3
Compare
Description
Closes #3789
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)