Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup JSON instances for Conway governance #3797

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Oct 17, 2023

Description

This is a collection of small JSON related issues.

Also addition of Assertions for EPOCH rule that verify that withdrawals and treasury fields of EnactState are always zero before and after the EPOCH rule.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested review from Soupstraw and TimSheard October 17, 2023 23:48
@lehins lehins force-pushed the lehins/cleanup-enact-state branch from e2a6954 to 2c9696c Compare October 18, 2023 00:34
@lehins lehins force-pushed the lehins/cleanup-enact-state branch from 2c9696c to 52f9ec7 Compare October 18, 2023 09:46
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins enabled auto-merge October 19, 2023 10:13
@lehins lehins merged commit ef006a8 into master Oct 19, 2023
@iohk-bors iohk-bors bot deleted the lehins/cleanup-enact-state branch October 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants