Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes needed for 8.6 release #3799

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Changes needed for 8.6 release #3799

merged 2 commits into from
Oct 25, 2023

Conversation

teodanciu
Copy link
Contributor

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/release-8.6.0 branch 3 times, most recently from 35bce50 to 25bc2c5 Compare October 24, 2023 13:43
@teodanciu teodanciu changed the title Changes needed for 8.6 release [WIP] Changes needed for 8.6 release Oct 25, 2023
@teodanciu teodanciu marked this pull request as ready for review October 25, 2023 09:26
lehins
lehins approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins merged commit 1b79249 into master Oct 25, 2023
10 of 14 checks passed
@iohk-bors iohk-bors bot deleted the td/release-8.6.0 branch October 25, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teodanciu @lehins