Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delegation validation #3803

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix delegation validation #3803

merged 3 commits into from
Oct 24, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Oct 23, 2023

Description

Fixes #3802

Problem was in the fact that we added new certificate type that allows for delegation and registration at the same time, which did not participate in validation of StakePool existence.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from aniketd October 23, 2023 13:46
@lehins lehins force-pushed the lehins/fix-delegation-validation branch from 69c615a to b2d790c Compare October 23, 2023 13:48
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a question for my own education.

@lehins lehins force-pushed the lehins/fix-delegation-validation branch from c636587 to 4c4f30d Compare October 24, 2023 10:47
@lehins lehins enabled auto-merge October 24, 2023 10:48
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks! 🙌

@lehins lehins force-pushed the lehins/fix-delegation-validation branch from 4c4f30d to b6f93ef Compare October 24, 2023 13:35
@lehins lehins force-pushed the lehins/fix-delegation-validation branch from b6f93ef to d68e427 Compare October 24, 2023 15:53
@lehins lehins merged commit ad3f40a into master Oct 24, 2023
@iohk-bors iohk-bors bot deleted the lehins/fix-delegation-validation branch October 24, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency on delegation certificates
3 participants