-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDDL roundtrip testing #3809
Merged
Merged
CDDL roundtrip testing #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52ff181
to
424436a
Compare
* Switch `cardano-ledger-shelley` to use new hspec CDDL testing * Move CDDL files to `cardano-ledger-shelley` * Make `cardano-protocol-tpraos` use cddl spec from other eras * Improve and export `embedTripLabelExtra`
9f9ff8f
to
d14aafa
Compare
d14aafa
to
2d63451
Compare
2d63451
to
a01f7da
Compare
nc6
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with the documentation of readProcessNoFailure
, otherwise everything is minor and may be addresssed/dismissed as desired.
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/Cddl.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/Cddl.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/Cddl.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/Cddl.hs
Outdated
Show resolved
Hide resolved
aniketd
reviewed
Oct 26, 2023
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/Cddl.hs
Outdated
Show resolved
Hide resolved
aniketd
reviewed
Oct 26, 2023
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/Cddl.hs
Outdated
Show resolved
Hide resolved
aniketd
reviewed
Oct 26, 2023
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/Cddl.hs
Outdated
Show resolved
Hide resolved
aniketd
reviewed
Oct 26, 2023
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/Cddl.hs
Outdated
Show resolved
Hide resolved
aniketd
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🙌
eb50032
to
c449047
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cardano-protocol-tpraos
, rather than run it in shelley.Noticeable speed up in the CDDL testing. This is new:
vs old:
Which means we can add some more CDDL tests.
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)