Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent voting on expired GovActions #3825

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Prevent voting on expired GovActions #3825

merged 2 commits into from
Oct 30, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Oct 27, 2023 •
edited

Description

Closes #3804

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/prevent-voting-on-expired-actions branch 3 times, most recently from 426b716 to 7154f3e Compare October 27, 2023 12:43
lehins
lehins approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

eras/conway/impl/test/Test/Cardano/Ledger/Conway/GovSpec.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/prevent-voting-on-expired-actions branch from 7154f3e to 4b709f5 Compare October 30, 2023 12:26
@lehins lehins merged commit 701c908 into master Oct 30, 2023
9 of 42 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/prevent-voting-on-expired-actions branch October 30, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@teodanciu teodanciu Awaiting requested review from teodanciu

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent voting on expired governance actions
2 participants
@aniketd @lehins