Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aeson to 2.2 #3830

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Bump aeson to 2.2 #3830

merged 1 commit into from
Oct 31, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Oct 31, 2023

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

hie.yaml Outdated Show resolved Hide resolved
@carbolymer carbolymer force-pushed the mgalazyn/chore/bump-aeson-2.2 branch 4 times, most recently from 3c41298 to 16dc7e0 Compare October 31, 2023 10:42
@carbolymer carbolymer marked this pull request as ready for review October 31, 2023 10:42
@carbolymer carbolymer requested review from a team as code owners October 31, 2023 10:42
@teodanciu
Copy link
Contributor

teodanciu commented Oct 31, 2023

This looks good to me, however I would rather @lehins also approved this before merging, just in case he sees any potential problem or interference with the release we're trying to make.
Adding his as reviewer

@teodanciu teodanciu requested a review from lehins October 31, 2023 11:21
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Looks great!

@lehins lehins force-pushed the mgalazyn/chore/bump-aeson-2.2 branch from 16dc7e0 to 1b9e4a4 Compare October 31, 2023 13:35
@lehins lehins enabled auto-merge October 31, 2023 13:35
@lehins lehins merged commit f8c4944 into master Oct 31, 2023
@iohk-bors iohk-bors bot deleted the mgalazyn/chore/bump-aeson-2.2 branch October 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants