Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treasury withdrawal fix #3831

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Treasury withdrawal fix #3831

merged 2 commits into from
Oct 31, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Oct 31, 2023 •
edited
Loading

Description

Fixes #3827

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

This was referenced Oct 31, 2023
Merged
Merged
TimSheard
TimSheard approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes some redundant fields in the Pulser.
Changes algorithm to apply Enact State.
Looks good to me.

@lehins lehins force-pushed the lehins/treasury-withdrawal-fix branch from 63f405b to 52c39c4 Compare October 31, 2023 14:44
@lehins lehins enabled auto-merge October 31, 2023 14:44
@lehins lehins force-pushed the lehins/treasury-withdrawal-fix branch from 52c39c4 to 2f41c7c Compare October 31, 2023 16:24
@lehins lehins merged commit 5ea6e85 into master Oct 31, 2023
@iohk-bors iohk-bors bot deleted the lehins/treasury-withdrawal-fix branch October 31, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSheard TimSheard TimSheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Treasury withdrawal not happening
2 participants
@lehins @TimSheard