Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treasury withdrawals tests #3832

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Oct 31, 2023

Description

This PR reorganized the ImpTest framework a little. Gives it a bit more structure.

Adds ability to create reward accounts in ImpTest

Adds tests for TreasuryWithdrawals that replicate #3827 bug and confirm #3831 fix

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too familiar with the framework, but the new code has more structure, so that is good.

@lehins lehins force-pushed the lehins/treasury-withdrawals-tests branch 2 times, most recently from c4b3e2e to a163cb6 Compare October 31, 2023 23:04
@lehins lehins force-pushed the lehins/treasury-withdrawals-tests branch from a163cb6 to d3186a5 Compare November 1, 2023 00:40
@lehins lehins enabled auto-merge November 1, 2023 00:40
@lehins lehins merged commit c617745 into master Nov 1, 2023
@iohk-bors iohk-bors bot deleted the lehins/treasury-withdrawals-tests branch November 1, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants