PParamsUpdate enactment fix #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
changed the base branch from
master
to
lehins/treasury-withdrawals-tests
lehins
changed the base branch from
lehins/treasury-withdrawals-tests
to
master
lehins
force-pushed
the
lehins/pparamsupdate-enactment-tests
branch
2 times, most recently
from
7caefa5
to
81f8116
Compare
Soupstraw
reviewed
Nov 1, 2023
Soupstraw
reviewed
Nov 1, 2023
Soupstraw
reviewed
Nov 1, 2023
lehins
force-pushed
the
lehins/pparamsupdate-enactment-tests
branch
from
81f8116
to
617b033
Compare
lehins
force-pushed
the
lehins/pparamsupdate-enactment-tests
branch
from
617b033
to
3299f62
Compare
teodanciu
reviewed
Nov 2, 2023
teodanciu
reviewed
Nov 2, 2023
teodanciu
reviewed
Nov 2, 2023
teodanciu
reviewed
Nov 2, 2023
teodanciu
approved these changes
Nov 2, 2023
This is very important, otherwise we can't figure out the group and thus the threshold for DReps, making a proposla trivially enactable, with the CC support that is. Related change to the spec: IntersectMBO/formal-ledger-specifications#274
lehins
force-pushed
the
lehins/pparamsupdate-enactment-tests
branch
from
3299f62
to
c60566c
Compare
This is an alternative approach to figuring out thresholds. Original approach was buggy and did not work correctly, which resulted in #3835 Bring back the module Bring back the module
lehins
force-pushed
the
lehins/pparamsupdate-enactment-tests
branch
from
c60566c
to
ee3192c
Compare
GHC-8.10 has a bug where current setup of type families and usage of type class functions to define standalone functions that depnend on the same type class results in compiler going into infinite loop. GHC bug report: https://gitlab.haskell.org/ghc/ghc/-/issues/21973
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3835
Original implementation was buggy and did not produced any groups for PParam groups, which resulted in DRep thresholds to be set to zero for PParamUpdates, yielding all PParam proposals be enacted, regardless on what DReps though about them 😄
One more fix included is a PParamUpdate wellformdness check that ensures empty PParams can't be proposed.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)