Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix anomalies in Deposits in the Conway Era #3840

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix anomalies in Deposits in the Conway Era #3840

merged 1 commit into from
Nov 7, 2023

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Nov 1, 2023 •
edited
Loading

Fixes #3834

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@TimSheard TimSheard force-pushed the ts-issue3834-depositFixes branch from da5c9d7 to da3ce20 Compare November 1, 2023 15:46
@lehins lehins changed the title Fix anomalies in Deposits in the Conway Era (Issue #3834) Fix anomalies in Deposits in the Conway Era Nov 1, 2023
@TimSheard TimSheard force-pushed the ts-issue3834-depositFixes branch 2 times, most recently from 2b37059 to 9eaf282 Compare November 1, 2023 20:19
@TimSheard TimSheard requested a review from lehins November 1, 2023 23:08
lehins
lehins approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you

libs/cardano-ledger-core/src/Cardano/Ledger/CertState.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/CertState.hs Outdated Show resolved Hide resolved
teodanciu
teodanciu approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, so the reason the assertion wasn't failing is because the value happened to be missing from both sides of the equation I suppose.
Looks good to me.

@TimSheard TimSheard force-pushed the ts-issue3834-depositFixes branch 2 times, most recently from 447800b to 54fffe6 Compare November 7, 2023 12:42
@lehins lehins enabled auto-merge November 7, 2023 13:45
@lehins lehins force-pushed the ts-issue3834-depositFixes branch from 54fffe6 to c090439 Compare November 7, 2023 16:22
@lehins lehins merged commit a505e7a into master Nov 7, 2023
@iohk-bors iohk-bors bot deleted the ts-issue3834-depositFixes branch November 7, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodanciu teodanciu teodanciu approved these changes

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix anomalies in Deposits in the Conway Era.
3 participants
@TimSheard @teodanciu @lehins