Imp improvements #3842
Merged
Imp improvements #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/imp-improvements
branch
from
b5266b4 to
0ca8d62
Compare
aniketd
approved these changes
Nov 2, 2023
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Imp/Common.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs
Outdated
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/imp-improvements
branch
from
b188eeb to
222a01d
Compare
Soupstraw
reviewed
Nov 2, 2023
Soupstraw
approved these changes
Nov 2, 2023
lehins
force-pushed
the
lehins/imp-improvements
branch
5 times, most recently
from
2b509e5 to
719dd6e
Compare
* Rewrite `ImpTestM` as `ReaderT` with `IORef` and change `MonadState` instance. * Add `Example` instance for `ImpTestM`, that integrates it into HSpec * Failure reporting and logging works nicely * Introduce new expectations that work with Either * Add lifted versions of expectations to a new `Test.Cardano.Ledger.Imp.Common` module * Make GovSpec polymorphic in `era`. Fix and improve some of the tests.
lehins
force-pushed
the
lehins/imp-improvements
branch
from
719dd6e to
ab40c97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A whole bunch of improvements to Imp Spec
MonadIOimpAnnOther relevant changes:
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)