-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plutus modules restructure #3848
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0c8411
to
40c5cec
Compare
9 tasks
995ac9a
to
afa512f
Compare
Soupstraw
approved these changes
Nov 7, 2023
teodanciu
reviewed
Nov 7, 2023
teodanciu
reviewed
Nov 7, 2023
teodanciu
reviewed
Nov 7, 2023
teodanciu
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions about version adjustments.
Awesome git discipline 🤩
Looks good to me.
Make 3 exact copies of the Scripts file, in order to preserve the git history
Move back the original Scripts file
Remove all of the duplicate code from the three modules and re-export ExUnits and CostModels from Scripts
Make three identical copies in order to preserve git history: * `Cardano.Ledger.Plutus.TxInfo` * `Cardano.Ledegr.Plutus.Evaluate` * `Cardano.Ledger.Alonzo.Plutus.TxInfo`
* Add deprecation module for `Cardano.Ledger.Alonzo.TxInfo` * Remove duplicate functionality
afa512f
to
ec96724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first stage in untangling Plutus mess. Initial step for #3849
There are no semantic changes in this PR. It only organizes the location of the code. All of the Plutus specific functionality that is era agnostic has been moved into core and organized logically into separate modules. All of git history is preserved, despite what the github diff portrays, which is important that the commits are not squashed together, because history will be lost if that happens.
Here is the re-organization:
Cardano.Ledger.Language
toCardano.Ledger.Plutus.Language
Cardano.Ledger.Alonzo.Scripts.Data
toCardano.Ledger.Plutus.Data
ExUnits
andPrices
functionality fromCardano.Ledger.Alonzo.Scripts
intoCardano.Ledger.Plutus.ExUnits
module.CostModel
andCostModels
functionality fromCardano.Ledger.Alonzo.Scripts
intoCardano.Ledger.Plutus.CostModels
module.Cardano.Ledger.Alonzo.TxInfo
intoCardano.Ledger.Plutus.Evaluate
Cardano.Ledger.Alonzo.TxInfo
intoCardano.Ledger.Plutus.TxInfo
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)