Fix strange assertion failure, which hides real Block too big problem. #3853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request 3828, had a strange failure in the LEDGER rule in the Allegra era. It turns out that an underlying predicate failuure
RealChainPredicateFailure (BlockSizeTooLargeCHAIN 59587 54943) was setting the assertion failure off.
It appears that generating
Block traces ( Test.Cardano.Ledger.Shelley.Generator.Block(genBlockWithTxGen))
occasionally generates blocks that are slightly too big. So this is a failure of the test framework, not the system. We fix this by altering that function to discard, if the generated Block is too big.
This is also the cause of failures in PR 3848. Fixes #3851
Description
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)