Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration work for node 8.7.0 #3854

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Integration work for node 8.7.0 #3854

merged 2 commits into from
Nov 14, 2023

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Nov 7, 2023

Description

  • Updates streaming-binary dependency from cardano-ledger-byron
  • Fixes the paths to the cddl data files.
  • Uses buildable = False instead of package.buildable = False in Nix-Windows

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch 3 times, most recently from 95c4efe to 5c7eeaf Compare November 10, 2023 12:40
@jasagredo jasagredo marked this pull request as ready for review November 10, 2023 12:42
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from 5c7eeaf to 092a6e5 Compare November 10, 2023 12:44
@jasagredo jasagredo changed the title WIP: Integration work for node 8.7.0 Integration work for node 8.7.0 Nov 10, 2023
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great! 👍

@lehins lehins enabled auto-merge November 10, 2023 12:48
@lehins lehins disabled auto-merge November 10, 2023 12:52
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from 092a6e5 to 341142b Compare November 10, 2023 12:52
@jasagredo jasagredo requested review from a team as code owners November 10, 2023 12:52
@jasagredo jasagredo enabled auto-merge November 10, 2023 12:54
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch 2 times, most recently from 0e9a468 to f1241e7 Compare November 13, 2023 12:18
@lehins lehins disabled auto-merge November 13, 2023 13:20
@lehins lehins marked this pull request as draft November 13, 2023 13:20
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from f1241e7 to 81f8bf1 Compare November 14, 2023 11:51
@jasagredo jasagredo marked this pull request as ready for review November 14, 2023 12:05
@jasagredo jasagredo enabled auto-merge November 14, 2023 12:19
@jasagredo jasagredo merged commit 1faa5d1 into master Nov 14, 2023
@iohk-bors iohk-bors bot deleted the jasagredo/node-8.7.0 branch November 14, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants