Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ProposalsSnapshot to Proposals #3859

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Nov 9, 2023

Description

Closes #3857

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu
Copy link
Contributor

Do we need to increment, in cardano-ledger-pretty package, the version bound of cardano-ledger-conway to 1.11.0 ?
https://github.com/input-output-hk/cardano-ledger/blob/aniketd/rename-snapshots-to-proposals/libs/cardano-ledger-pretty/cardano-ledger-pretty.cabal#L43

Looks good to me otherwise.

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to increment, in cardano-ledger-pretty package, the version bound of cardano-ledger-conway to 1.11.0 ?

Yes we do

@aniketd aniketd force-pushed the aniketd/rename-snapshots-to-proposals branch from a1abd7a to de7515e Compare November 10, 2023 10:06
@aniketd
Copy link
Contributor Author

aniketd commented Nov 10, 2023

Thanks for the reviews! I have implemented the suggestions and pushed the update.

@aniketd aniketd enabled auto-merge (squash) November 10, 2023 10:18
@lehins
Copy link
Collaborator

lehins commented Nov 10, 2023

@aniketd Looks like my PR created a conflict for you.

@aniketd
Copy link
Contributor Author

aniketd commented Nov 10, 2023

No worries @lehins! I got it!

* Rename module Governance.Snapshots to Governance.Proposals.
* Rename all functions related to the proposals data-type.
@aniketd aniketd disabled auto-merge November 10, 2023 13:11
@aniketd aniketd force-pushed the aniketd/rename-snapshots-to-proposals branch from de7515e to 526cc62 Compare November 10, 2023 13:24
@aniketd aniketd enabled auto-merge (squash) November 10, 2023 13:25
@aniketd aniketd merged commit f7f6479 into master Nov 10, 2023
@iohk-bors iohk-bors bot deleted the aniketd/rename-snapshots-to-proposals branch November 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ProposalsSnapshots to Proposals
3 participants