-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ProposalsSnapshot to Proposals #3859
Conversation
Do we need to increment, in cardano-ledger-pretty package, the version bound of cardano-ledger-conway to 1.11.0 ? Looks good to me otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to increment, in cardano-ledger-pretty package, the version bound of cardano-ledger-conway to 1.11.0 ?
Yes we do
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs
Outdated
Show resolved
Hide resolved
a1abd7a
to
de7515e
Compare
Thanks for the reviews! I have implemented the suggestions and pushed the update. |
@aniketd Looks like my PR created a conflict for you. |
No worries @lehins! I got it! |
* Rename module Governance.Snapshots to Governance.Proposals. * Rename all functions related to the proposals data-type.
de7515e
to
526cc62
Compare
Description
Closes #3857
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)