Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mock/crypto.cddl, added optional tag to sets #3860

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 9, 2023

Description

This PR adds an optional tag to set and nonempty_set in the CDDL.
Also removed the mock directory and moved the files from real directory to cddl-files.

resolves #3845
resolves #3820

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw changed the title Removed mock/crypto.cddl, added optional tag to sets Removed mock/crypto.cddl, added optional tag to sets Nov 9, 2023
@Soupstraw Soupstraw marked this pull request as ready for review November 9, 2023 15:13
@Soupstraw Soupstraw marked this pull request as draft November 9, 2023 15:35
@Soupstraw Soupstraw force-pushed the jj/cddl-set-tag branch 2 times, most recently from c55ba8e to 955d35f Compare November 9, 2023 16:13
@Soupstraw Soupstraw marked this pull request as ready for review November 9, 2023 16:17
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup! Thank you!

eras/conway/impl/cddl-files/extra.cddl Show resolved Hide resolved
@lehins lehins merged commit 67a6293 into master Nov 10, 2023
8 of 296 checks passed
@iohk-bors iohk-bors bot deleted the jj/cddl-set-tag branch November 10, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CDDL to indicate Set tag Remove cddl-files/mock/crypto.cddl
2 participants