Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaryValue fixes #3867

Merged
merged 3 commits into from
Nov 13, 2023
Merged

MaryValue fixes #3867

merged 3 commits into from
Nov 13, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Nov 10, 2023

Description

This PR split into 3 major commits (thus it probably would be easier to review commit by commit)

  • improves MaryValue generators
  • fixes MaryValue deserialization. It reverts back the enforcement of positive ADA in the MaryValue back to non-negative ADA. This must be the case due to possibility of zero ADA in ValueNotConservedUTxO.
  • Changes type for ADA in MaryValue from Integer to Coin

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins changed the title Lehins/mary value fixes MaryValue fixes Nov 11, 2023
@lehins lehins force-pushed the lehins/mary-value-fixes branch 2 times, most recently from 78ddbf8 to 14e7278 Compare November 13, 2023 15:31
@lehins lehins marked this pull request as ready for review November 13, 2023 16:23
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only thing that looks strange is the missing EncCBOR instance.

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins merged commit cf32eab into master Nov 13, 2023
8 of 58 checks passed
@iohk-bors iohk-bors bot deleted the lehins/mary-value-fixes branch November 13, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants