Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release changes #3874

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Post release changes #3874

merged 3 commits into from
Nov 16, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Nov 15, 2023

Description

Some cleanup and needed changes:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested review from a team as code owners November 15, 2023 20:07
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plutus-core dependency was removed from these packages: alonzo, alonzo-test and core.
I wonder why we also updated the cabal versions of: babbage, conway and binary in addition to the three for which plutus was removed?

@lehins
Copy link
Contributor Author

lehins commented Nov 16, 2023

I wonder why we also updated the cabal versions of: babbage, conway and binary in addition to the three for which plutus was removed?

@teodanciu The answer is in the PR description:

#3871 did not include the necessary version bumps

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

* Bump up versions that that are needed for #3871
* Update changelogs needed as post release process for recent
  CHaP release: https://github.com/input-output-hk/cardano-haskell-packages/pull/560
@lehins lehins merged commit 8077fb7 into master Nov 16, 2023
9 of 20 checks passed
@iohk-bors iohk-bors bot deleted the lehins/post-release-changes branch November 16, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants