Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cddl spec for CostModels in Conway #3875

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Nov 15, 2023

Description

Fixing CDDL tests. CostModel deserialization was fixed, y making it stricter for PParamsUpdate in #3861

Received this error on CI: https://github.com/input-output-hk/cardano-ledger/actions/runs/6882361340/job/18720713406?pr=3874#step:15:4026

       Decoder error: Deserialisation failure while decoding GovAction (ConwayEra StandardCrypto).
       CBOR failed with error: DeserialiseFailure 41 "CMTooFewParamsError {cmTooFewExpected = 175, cmTooFewActual = 1}"

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from teodanciu November 15, 2023 21:33
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, sorry for not catching this when I made the change.
Looks good to me

@lehins lehins merged commit 5f9ac0c into master Nov 16, 2023
@iohk-bors iohk-bors bot deleted the lehins/fix-costmodel-cddl branch November 16, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants