-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 4 PParam fields from EpochNo to EpochInterval #3876
Conversation
90db057
to
2567856
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Thank you!
2567856
to
8cb1eba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably was not to clear when I was explaining those bounds and versions. Hopefully my comments will clarify it a bit. Let me know if it still confusing and we can talk about it on Monday
043796c
to
0282d38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more minor changes are still needed. Looking very nice though!
a926282
to
78e3a8e
Compare
Changed 3 PParam fields from EpochNo to EpochInterval Changed cabal versions
78e3a8e
to
2271b2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more things. Almost there.
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience and your work on this PR!
`cardano-ledger-alonzo-test-1.1.2.8` has not been released yet, so the version bump in #3876 was incorrect
`cardano-ledger-alonzo-test-1.1.2.8` has not been released yet, so the version bump in #3876 was incorrect
`cardano-ledger-alonzo-test-1.1.2.8` has not been released yet, so the version bump in #3876 was incorrect
EpochNo represents a fixed point in time. Sometimes we want to talk about a positive delta in this space. We used to also use EpochNo for this purpose, but this was confusing, since the EpochNo used could be negative.
To Fix this we introduce the newtype EpochInterval, and the function
addEpochInterval :: EpochNo -> EpochInterval -> Epoch No
Fixes #3870
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)