Remove generic-monoid dependency #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/generic-monoid
branch
from
ce3ebd5 to
dd10075
Compare
erikd
force-pushed
the
erikd/generic-monoid
branch
from
dd10075 to
775a974
Compare
|
The Nix/CI failure seems to be due to a missing |
lehins
approved these changes
Nov 17, 2023
This package on Hackage has no githib (or similar) repository listed, has no contact email address and does not build with ghc-9.8. Its only used for a single two element sum type for which hand written Monoid and Semigroup instances are trivial.
erikd
force-pushed
the
erikd/generic-monoid
branch
from
472fc55 to
b9e02d1
Compare
erikd
force-pushed
the
erikd/generic-monoid
branch
from
b9e02d1 to
bee4092
Compare
|
@lehins Can this be merged as it is or must the Nix/CI failures be fixed? |
Nope it is not a must. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This package on Hackage has no githib (or similar) repository listed, has no contact email address and does not build with ghc-9.8.
Its only used for a single two element sum type for which a hand written Monoid and Semigroup instances is trivial.
Fixes #3879
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)