-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Committee QuerySpec Imp Test #3883
Merged
teodanciu
merged 4 commits into
td/committee-query-next-epoch-change
from
td/committee-query-imp-test
Dec 5, 2023
Merged
Committee QuerySpec Imp Test #3883
teodanciu
merged 4 commits into
td/committee-query-next-epoch-change
from
td/committee-query-imp-test
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d20e6d4
to
8ad77ee
Compare
7e2b0d3
to
ab4580e
Compare
teodanciu
commented
Nov 21, 2023
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/Imp/QuerySpec.hs
Outdated
Show resolved
Hide resolved
8ad77ee
to
d191696
Compare
ab4580e
to
2a3f580
Compare
lehins
reviewed
Nov 22, 2023
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/Imp/QuerySpec.hs
Show resolved
Hide resolved
lehins
reviewed
Nov 22, 2023
3b56368
to
78d886d
Compare
2a3f580
to
be3ab3f
Compare
78d886d
to
e5b85cd
Compare
f9e10b8
to
e597e49
Compare
9 tasks
Soupstraw
approved these changes
Dec 4, 2023
lehins
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!!!! I love how clear and readable those test cases are!
❤️
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/Imp/QuerySpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/Imp/QuerySpec.hs
Show resolved
Hide resolved
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/Imp/QuerySpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/Imp/QuerySpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/Imp/QuerySpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/Imp/QuerySpec.hs
Outdated
Show resolved
Hide resolved
lehins
approved these changes
Dec 4, 2023
d161ed6
to
3d7fec6
Compare
baa917c
to
a920778
Compare
43b1122
to
e2310f7
Compare
8331c1c
to
ddb7933
Compare
e2310f7
to
eaab9e7
Compare
ddb7933
to
82e75cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3881
Depends on: #3878
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)