Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committee QuerySpec Imp Test #3883

Merged

Conversation

teodanciu
Copy link
Contributor

Description

Closes #3881

Depends on: #3878

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/committee-query-next-epoch-change branch from d20e6d4 to 8ad77ee Compare November 21, 2023 14:09
@teodanciu teodanciu force-pushed the td/committee-query-next-epoch-change branch from 8ad77ee to d191696 Compare November 21, 2023 17:12
@teodanciu teodanciu force-pushed the td/committee-query-next-epoch-change branch 4 times, most recently from 3b56368 to 78d886d Compare November 23, 2023 18:05
@teodanciu teodanciu force-pushed the td/committee-query-next-epoch-change branch from 78d886d to e5b85cd Compare November 24, 2023 01:23
@teodanciu teodanciu force-pushed the td/committee-query-imp-test branch 2 times, most recently from f9e10b8 to e597e49 Compare November 24, 2023 12:11
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!!!! I love how clear and readable those test cases are!
❤️

@teodanciu teodanciu force-pushed the td/committee-query-next-epoch-change branch 2 times, most recently from d161ed6 to 3d7fec6 Compare December 4, 2023 23:47
@teodanciu teodanciu force-pushed the td/committee-query-imp-test branch 2 times, most recently from baa917c to a920778 Compare December 5, 2023 00:40
@teodanciu teodanciu force-pushed the td/committee-query-next-epoch-change branch 2 times, most recently from 43b1122 to e2310f7 Compare December 5, 2023 13:43
@teodanciu teodanciu force-pushed the td/committee-query-imp-test branch 2 times, most recently from 8331c1c to ddb7933 Compare December 5, 2023 14:00
@teodanciu teodanciu force-pushed the td/committee-query-next-epoch-change branch from e2310f7 to eaab9e7 Compare December 5, 2023 14:01
@teodanciu teodanciu merged commit e1adbd7 into td/committee-query-next-epoch-change Dec 5, 2023
5 of 9 checks passed
@iohk-bors iohk-bors bot deleted the td/committee-query-imp-test branch December 5, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants