Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requirement on the Set tag 258 to be enforced in the next era #3884

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Nov 21, 2023

Description

It seems like this one era is not enough for some tools and HW to catch up with a change like that, so this tag is planned to be enforced two eras after Conway, rather than the next era.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins force-pushed the lehins/relax-set-tag branch from ea19ee7 to 3582397 Compare November 21, 2023 16:06
@lehins lehins enabled auto-merge November 21, 2023 16:06
It seems like this one era is not enough for some tools and HW to catch
up with a change like that, so this tag is planned to be enforced
two eras after Conway, rather than the next era.
@lehins lehins force-pushed the lehins/relax-set-tag branch from 3582397 to 01de0ee Compare November 21, 2023 18:28
@lehins lehins merged commit bd18371 into master Nov 21, 2023
@iohk-bors iohk-bors bot deleted the lehins/relax-set-tag branch November 21, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants