Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test for genTxAndNewEpoch #3885

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 21, 2023

Description

Adds a test for genTxAndNewEpoch that checks whether the generator successfully generates a value. Moved some functions from Examples to Utils.

@TimSheard helped me find and fix the bug and now the test should pass

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw marked this pull request as ready for review November 21, 2023 14:35
@Soupstraw Soupstraw force-pushed the jj/nes-tx-generator-test branch from 29e23af to 22e1912 Compare November 21, 2023 14:36
@Soupstraw Soupstraw force-pushed the jj/nes-tx-generator-test branch 4 times, most recently from 6da1f3e to 1d80aa8 Compare November 21, 2023 15:56
@Soupstraw Soupstraw enabled auto-merge (rebase) November 21, 2023 15:58
@Soupstraw Soupstraw force-pushed the jj/nes-tx-generator-test branch from ad1cd5d to 57e71a6 Compare November 21, 2023 16:13
@Soupstraw Soupstraw merged commit 653cbff into master Nov 21, 2023
@iohk-bors iohk-bors bot deleted the jj/nes-tx-generator-test branch November 21, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants