-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tree-diff
dependency to tests together with all instances
#3893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of moving the instances, however the way cabal files were adjusted is totally wrong
0de4870
to
10cdf38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a bunch of unnecessary adjustments to bounds of dependencies, mostly for *-test
packages, but other than that this PR is beautiful. Thank you for doing all this work!!!!
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/TreeDiff.hs
Outdated
Show resolved
Hide resolved
bb315d7
to
65a71d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing stuff! Thank you for doing this! 👍
65a71d4
to
a98672a
Compare
Fix a mistake introduced in #3893.
Fix this mistake of exporting the `CostModel` cpnstructor that was introduced in #3893.
Fix this mistake of exporting the `CostModel` constructor, which was introduced in #3893.
Fix this mistake of exporting the `CostModel` constructor, which was introduced in #3893.
Fix this mistake of exporting the `CostModel` constructor, which was introduced in #3893.
Fix this mistake of exporting the `CostModel` constructor, which was introduced in #3893.
Description
tree-diff
uses GPL license so it should not be in the non-testing code in our case. This PR moves all the instances to the test packages so that only when testing this dependency is pulled in. See how when requesting to build just the libraries, notree-diff
is pulled from hackage:The PR is very verbose, but consists just of moving things around and exporting some internal constructors so that GHC can derive the instance in a separate module.
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)