Fix pvCanFollow usage in Conway and improve clarity in Shelley #3902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix wrong usage of
pvCanFollow
in Conway: fix #3901 and fix #3873This problem happened because there was no documentation on
pvCanFollow
and names for bindings where totally useless. This proves my belief even further that ticks are not very useful for bindings.Besides the bug fix this PR also includes:
pvCanFollow
match the spec and remove theSNothing
wrapperaround the newly proposed
ProtVer
hasLegalProtVerUpdate
failOnJust
,failOnNonEmpty
,failureOnJust
,failureOnNonEmpty
tosmall-steps
, which allow us to lazily get theoffending value, without forcing the validation, when validation is
turned off.
cardano-ledger-alonzo-test-1.1.2.8
has not been released yet, so theversion bump in Change 4 PParam fields from EpochNo to EpochInterval #3876 was incorrect
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)